Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate: Root newline change in snapshot update #286 #287

Closed
asraa opened this issue Jun 23, 2022 · 2 comments
Closed

Investigate: Root newline change in snapshot update #286 #287

asraa opened this issue Jun 23, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@asraa
Copy link
Contributor

asraa commented Jun 23, 2022

Description

Investigate:

@joshuagl @dlorenc

@asraa asraa added the enhancement New feature or request label Jun 23, 2022
@asraa
Copy link
Contributor Author

asraa commented Jul 1, 2022

This is actually causing me problems in the verifier.
Before the newline was removed, the targets file had 3972 bytes. Old TUF clients (before commit theupdateframework/go-tuf#247) cannot verify metadata with the newline:

asraa@asraa1:~/git/go-tuf$ ./tuf-client list -s /tmp/tuf.db http://localhost:8001
ERROR: tuf: unexpected file size: targets.json (expected 3971 bytes, got 3972 bytes)

The client at head CAN verify with either the newline present or removed.


Now, however, when we initialize a new root, we are adding the newline BACK. This means old clients cannot verify the change.

I'm still trying to figure out where we're using an old version of the client. I don't know why we are hitting the error.

@haydentherapper
Copy link
Contributor

I don't think this should be relevant anymore and we haven't seen this issue in some time. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants