Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize the Rust codegen #115

Closed
woodruffw opened this issue Jul 31, 2023 · 2 comments · Fixed by #118
Closed

Optimize the Rust codegen #115

woodruffw opened this issue Jul 31, 2023 · 2 comments · Fixed by #118
Assignees
@jleightcap
Labels
rust Rust bindings

Comments

@woodruffw
Copy link
Member

The Rust codegen appears to do a pretty heavy build on each make all; we should try to either eliminate that build or simplify it.

CC @jleightcap
@woodruffw woodruffw added the rust Rust bindings label Jul 31, 2023
@jleightcap jleightcap mentioned this issue Aug 2, 2023
Merged
@woodruffw
Copy link
Member Author

I think #118 will resolve this, since we're switching away from the AOT codegen strategy.

@jleightcap
Copy link
Contributor

I think #118 will resolve this, since we're switching away from the AOT codegen strategy.

https://github.com/sigstore/protobuf-specs/actions/runs/5754486332 -- building took 43s on latest run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jleightcap jleightcap

Labels
rust Rust bindings
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pb-rust: JSON schema compilation source trail-of-forks/protobuf-specs
2 participants
@woodruffw @jleightcap