Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All log messages have an error severity #641

Closed
haydentherapper opened this issue Jun 7, 2022 · 1 comment · Fixed by #648 or #673
Closed

All log messages have an error severity #641

haydentherapper opened this issue Jun 7, 2022 · 1 comment · Fixed by #648 or #673
Labels
bug Something isn't working

Comments

@haydentherapper
Copy link
Contributor

Found by looking at the logs on the GCP project. Some guesses to the source of the bug:

Everything might be severe by default:

cfg.EncoderConfig.LevelKey = "severity"

No logic to differentiate between OK and non-OK:

ctxzap.Extract(ctx).Check(level, msg).Write(

@haydentherapper haydentherapper added the bug Something isn't working label Jun 7, 2022
@haydentherapper
Copy link
Contributor Author

Can't reproduce this on the command line, so it might be an ingestion issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants