Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to hide docker-reference in identity section while verifying the docker image #3012

Closed
reds7373 opened this issue May 28, 2023 · 6 comments
Labels
no-issue-activity question Further information is requested

Comments

@reds7373
Copy link

Question
Is there a way to not include/hide the docker-reference which shows private registry details for us when verifying the signed docker images using the public key

[{"critical":{"identity":{"docker-reference":"internal-docker-registry/hello-world"},"image":{"docker-manifest-digest":"sha256:df48083e8dc43ccb8c3ba2d49bf15c7dce3507797dbc8d3331df937a5aac904f"},"type":"cosign container image signature"},"optional":null}]

the command used for signing the image:
cosign sign --key "private-key" internal-docker-registry/hello-world@sha256:df48083e8dc43ccb8c3ba2d49bf15c7dce3507797dbc8d3331df937a5aac904f

the command used to verify the docker image:
cosign verify --key ~/cosign-public-key.pub internal-docker-registry/hello-world@sha256:df48083e8dc43ccb8c3ba2d49bf15c7dce3507797dbc8d3331df937a5aac904f

@reds7373 reds7373 added the question Further information is requested label May 28, 2023
@znewman01
Copy link
Contributor

Take a look at #2984 (not merged yet) which adds support for a --sign-identity flag. This would let you set the docker-reference field to a value of your choosing.

Would that solve your issue?

@reds7373
Copy link
Author

reds7373 commented Jun 5, 2023

Thank you that PR #2984 should solve the issue @znewman01 is there a plan to port this Pr to version 1.13.1 as we are using internally cosign version 1.13.1

@reds7373 reds7373 closed this as completed Jun 5, 2023
@reds7373 reds7373 reopened this Jun 6, 2023
@znewman01
Copy link
Contributor

We have no plans to backport for now, though if enough folks need it we might consider it.

Can you share why you're still on 1.13? That's really useful feedback for us.

@shvam
Copy link

shvam commented Jun 12, 2023

We have no plans to backport for now, though if enough folks need it we might consider it.

Can you share why you're still on 1.13? That's really useful feedback for us.

Our requirement is to not upload the signer details or any other information to the transparency log.
When upgrading to Cosign v2.0.0 or later versions, we would like to avoid updating the cosign sign command (by specifying the option --tlog-upload=false) so that nothing gets uploaded to the transparency log.

Hence, it would be great if you could consider this :) . Thank you !

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions
Copy link

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-issue-activity question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants