Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make excluded istio attributes easily configurable #769

Closed
dmitryax opened this issue May 3, 2023 · 1 comment
Closed

Make excluded istio attributes easily configurable #769

dmitryax opened this issue May 3, 2023 · 1 comment
Labels
enhancement New feature or request Stale

Comments

@dmitryax
Copy link
Contributor

dmitryax commented May 3, 2023 •
edited
Loading

Follow-up for the discussion in #765 (comment)

Find a way to transition from

autodetect:
  istio: bool

to

autodetect:
  istio:
    enabled: true
    # Explain why we remove these default set of attributes
    excludeAttributes:
    - attr1
    - attr2

in backward compatible way
@dmitryax dmitryax added the enhancement New feature or request label May 3, 2023
@dmitryax dmitryax changed the title Make excluded istio attributes configurable Make excluded istio attributes easily configurable May 3, 2023
@dmitryax dmitryax mentioned this issue May 3, 2023
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023 •
edited by atoulme
Loading

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. If this issue is still relevant, please leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Oct 10, 2023
@atoulme atoulme closed this as not planned Won't fix, can't repro, duplicate, stale Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@atoulme @dmitryax