Do not play animated GIFs, stickers when Reduce Motion is on #5983
+133
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes signalapp#5949 by: - Disabling autoplay for GIFs, animated images, and animated stickers when Reduce Motion is on - Changing the `handleTap` behavior for stickers to play/pause the animation when the sticker is animated and Reduce Motion is on - Adding a new “Show Sticker Pack” item to the context menu when long-pressing a sticker, so that it’s still possible to see the pack when Reduce motion is enabled - Adding play button icons on top of GIFs and animated stickers to indicate that tapping will play the animation This also adds 2 new translation strings (for the “Show Sticker Pack” menu item). Unfortunately, I only know English, so that’s the only language I’ve added the translations to. This is also my first contribution to the Signal codebase, so please let me know if I should’ve done something a different way! I tried to make my changes as minimally disruptive as possible, and I don’t know whether I’ve done that at the expense of following existing style/conventions.
I discovered this while re-testing after merging in the recent changes. If Reduce Motion is *off*, opening a GIF would crash because the app couldn’t set up playback controls on the GIF player. This fix is starting to give me a whiff of code smell though, so I might need to refactor some of this…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Description
This fixes #5949 by:
handleTapbehavior for stickers to play/pause the animation when the sticker is animated and Reduce Motion is enabledThis also adds 2 new translation strings (for the “Show Sticker Pack” menu item). Unfortunately, I only know English, so that’s the only language I’ve added the translations to.
This is also my first contribution to the Signal codebase, so please let me know if I should’ve done something a different way! I tried to make my changes as minimally disruptive as possible, and I don’t know whether I’ve done that at the expense of following existing style/conventions.