-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
practical questions about schema #333
Comments
Lots of great points! Regarding the name of the files, it's common to use something-schema.json to distinguish it from any old JSON file, so that's where that came from. For versioning we've been using github tags and then referencing it in the id as https://raw.githubusercontent.com/sigmf/SigMF/v1.2.2/sigmf-schema.json so sounds like the suggestion is to use that value for the schema field too? |
yeah -- here's a branch https://github.com/gmabey/SigMF/tree/revised_extensions |
Yes
As long as the documentation & schema parsing software allow that, then yes.
Agree As for the version of the schema we discussed in the monthly call that we aren't synchronizing everything and we may need a process for that. We may need a separate issue for this. We need to synchronize:
|
Looks pretty good, but Since |
Hmm -- like a local As I've been looking at the "meta schema" https://json-schema.org/draft/2020-12/schema and I see an interesting feature that may be pertinent here: Could get complicated!
So, I tried to include a "solution" to this very important concept here: sigmf-wifi-schema.json line 3 |
I think I like |
":"
)sigmf-schema.json
would be renamedcore-schema.json
, for example. Is there a better way to definitely indicate the namespace of a schema? Or maybe a requirement that impliessigmf-core-schema.json
,sigmf-antenna-schema.json
.:
in it?"$schema"
field, which could have a version number embedded in it, as does that value inantenna-schema.json
. This implies that the"version"
field in the spec could change to"schema"
which would inherently include a name and a version. If you buy into that, then perhaps the"name"
field should change to"namespace"
...One conundrum I'm experiencing (that is motivating these questions) is that I attempted to validate a .sigmf-meta file against antenna-schema.json and it failed, because
antenna:model
is required. That's fine, but I see a need to correlate an item in "core:extensions" with a specific .json file, so that they can be selectively applied.If we agree that the namespace should be part of the schema filename, then I wonder whether there's a good reason for containing the community extensions within subdirectories. That is, if the file name contains the namespace, then that ought to be good enough for uniqueness. Any other information regarding the author or origin of the schema should probably be contained in
"description"
, no?[1] https://stackoverflow.com/questions/61077293/is-there-a-standard-for-specifying-a-version-for-json-schema
The text was updated successfully, but these errors were encountered: