Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.5 doesn't seem to be supported #225

Closed
spidru opened this issue Aug 31, 2021 · 2 comments
Closed

Python 3.5 doesn't seem to be supported #225

spidru opened this issue Aug 31, 2021 · 2 comments

Comments

@spidru
Copy link

spidru commented Aug 31, 2021

Hi there,

I'd like to report that I get the following error when trying to use Python 3.5:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/venv/lib/python3.5/site-packages/ytmusicapi/__init__.py", line 2, in <module>
    from ytmusicapi.ytmusic import YTMusic
  File "/home/venv/lib/python3.5/site-packages/ytmusicapi/ytmusic.py", line 10, in <module>
    from ytmusicapi.mixins.browsing import BrowsingMixin
  File "/home/venv/lib/python3.5/site-packages/ytmusicapi/mixins/browsing.py", line 278
    raise ValueError(f"The YouTube Channel {channelId} has no music content.")
                                                                            ^
SyntaxError: invalid syntax

My understanding is that f-strings were only introduced in Python 3.6, causing this syntax error. So I guess the README should be updated to "3.6 or higher" rather than "3.5 or higher"?

@sigma67
Copy link
Owner

sigma67 commented Sep 2, 2021

Hm it seems that one snuck in unnoticed during a recent PR. But Python 3.5 has reached end-of-life, so we should instead up version in the README as you suggested.

https://www.python.org/downloads/

@spidru
Copy link
Author

spidru commented Sep 6, 2021

Agreed. Let me know if you'd rather I create a PR for this.

@sigma67 sigma67 closed this as completed in 945b021 Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants