Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [Tab Tracking] Opening a session tracks it twice #1186

Open
Swivelgames opened this issue Apr 27, 2023 · 2 comments
Open

[BUG] [Tab Tracking] Opening a session tracks it twice #1186

Swivelgames opened this issue Apr 27, 2023 · 2 comments

Comments

@Swivelgames
Copy link

Short description

While tracking a Session in Tab Session Manager, opening up another session should not add it to the tracked session.

Steps to reproduce

This can be reproduced regardless of whether or not Session 2 is also tracked.

  1. Open a new window with the following tabs: Github.com, Amazon.com
  2. Save the window it as a session called Session 1
  3. Enable Tracking
  4. Repeat steps 1-5, but instead open: Google.com and name it Session 2
  5. Close Session 1 and Session 2
  6. In Tab Session Manager, open Session 1
  7. In Tab Session Manager, notice the Session 1 is tracking
  8. In Tab Session Manager, open Session 2
  9. In Tab Session Manager, notice the Session 2 is tracking
  10. In Tab Session Manager, observe that Session 1

Expected result

Session 1 has 1 Window, 2 Tabs

  • Github.com
  • Amazon.com

Session 2 has 1 Window, 1 Tab

  • Google.com

Actual result

Session 1 has 2 Window, 2 Tabs

  • Window 1
    • Github.com
    • Amazon.com
  • Window 2
    • Google.com

Session 2 has 1 Window, 1 Tab

  • Google.com

Platform information

  • Version of browser: Firefox 113.0b8 (64-bit)
  • Version of Tab Session Manager: 6.12.1
@vvirtues
Copy link

chrome_C0s5ASPAUM
This might not be what you're looking for, but see if it helps

@Swivelgames
Copy link
Author

@vvirtues A quick fix would be to disable tracking newly opened windows entirely, for sure. But the fact is that the Newly Opened Windows feature is currently buggy, and the tracking is a bit all over the place. The PR that I pushed up will fix this issue while also still being able to track newly opened windows 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants