Bug: document.body null causes exceptions when testing with cypress

[d-led]

What happened?

Problem

when testing an Angular Ix app with Cypress (e2e) and hovering over the test steps, the cypress-controlled browser throws exceptions in popover.util.ts:L37 or may hang.

Full reproduction step by step in a minimal repo: https://github.com/d-led/angular-ix-cypress#cypress-e2e-documentbody-is-null-in-popoverdestroy-bug-reproduction

What type of frontend frameware are you seeing the problem on?

Angular

Which version of iX do you use?

v1.2.1

Code to produce this issue.

https://github.com/d-led/angular-ix-cypress

[danielleroux]

@d-led tested it with your repository, but cannot reproduce it.

Screen.Recording.2023-01-12.at.09.16.55.mov

[d-led]

@danielleroux did you hover over the steps? visit, get, click, etc

[danielleroux]

@d-led i think this issue is more related to cypress ui not to ix.

[d-led]

as a clarification: cypress mounts a DOM snapshot when hovering over a step.

One can see it as a cypress issue or a robustness issue of ix. Cypress is a major UI automation tool and it's likely that users of ix will use it.

I've looked at the code, and specifically this event listener is set up on the document.body. Others, e.g. are set up on window. A different target or simply a null check would solve the problem in this case.

Other parts of ix seem to work fine with cypress

[d-led]

see a similar discussion: here & here

cypress runs the tests in an iframe if that helps

[danielleroux]

@d-led thank you for the detailed preparation 🎉. As discussed with the team we will merge #153 with 1.3.0. In this PR we removed this popover util class entirely.

[d-led]

@danielleroux superb. glad to hear!