Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] talosctl reboot doesn't work on omni nodes #177

Closed
1 task done
rsmitty opened this issue Apr 25, 2024 · 5 comments
Closed
1 task done

[bug] talosctl reboot doesn't work on omni nodes #177

rsmitty opened this issue Apr 25, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@rsmitty
Copy link
Member

rsmitty commented Apr 25, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Throws permission denied when issuing:

❯ talosctl -n talos-xxu-ebt reboot
◰ watching nodes: [talos-xxu-ebt]
* talos-xxu-ebt: rpc error: code = PermissionDenied desc = not authorized

Expected Behavior

talosctl reboot works to reboot the node in the same way that it does in the UI.

Steps To Reproduce

Issue talosctl reboot against a worker node in an omni-based cluster.

What browsers are you seeing the problem on?

No response

Anything else?

No response

@rsmitty rsmitty added the bug Something isn't working label Apr 25, 2024
@utkuozdemir
Copy link
Member

This is caused by the "action tracking" feature of talosctl that is enabled by default.

Action tracking feature shows the progress of the reboot. To be able to do that, it attempts to read the boot id before issuing the reboot GRPC call: https://github.com/siderolabs/talos/blob/main/cmd/talosctl/pkg/talos/action/tracker.go#L325-L341

We do not allow reading files even as admin in Omni.

Disabling action tracking by adding --wait=false to the command works as expected.

We can consider making the boot id readable (maybe expose it as a resource?) or using a fallback mechanism if we cannot read it.

@smira
Copy link
Member

smira commented Apr 29, 2024

We need two kinds of changes:

  • talosctl reboot to fall back to "regular" mode if it gets permission denied
  • figure out a way going forward (not sure what that would be?)

@utkuozdemir
Copy link
Member

Duplicate of siderolabs/talos#7197

will track it on the issue above.

@ArcherSeven
Copy link

@utkuozdemir how is this a duplicate of that card? I am an admin, and have not attempted to use "--wait" in any form, and am hitting this issue.

@smira
Copy link
Member

smira commented Apr 30, 2024

@ArcherSeven --wait=true is the default, just use --wait=false until we have a fix in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants