Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create input plugin component #47

Merged
merged 4 commits into from
Jul 23, 2023
Merged

feat: create input plugin component #47

merged 4 commits into from
Jul 23, 2023

Conversation

bpsmartdesign
Copy link
Collaborator

No description provided.

@driss-chelouati driss-chelouati changed the title Feat/input wrapper feat: create input plugin component Jul 15, 2023
driss-chelouati
driss-chelouati requested changes Jul 15, 2023
View reviewed changes
Copy link
Contributor

@driss-chelouati driss-chelouati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Floating label start position is wrong (probably based on the smaller size). Floating labels start position should be based on input size.

@stafyniaksacha stafyniaksacha merged commit 626a3bb into main Jul 23, 2023
@stafyniaksacha stafyniaksacha deleted the feat/input-wrapper branch July 23, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driss-chelouati driss-chelouati driss-chelouati approved these changes

@stafyniaksacha stafyniaksacha stafyniaksacha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bpsmartdesign @stafyniaksacha @driss-chelouati