Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create message plugin component #18

Merged
merged 5 commits into from
Jul 23, 2023
Merged

feat: create message plugin component #18

merged 5 commits into from
Jul 23, 2023

Conversation

bpsmartdesign
Copy link
Collaborator

No description provided.

Copy link
Contributor

@stafyniaksacha stafyniaksacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/plugins/components/message.ts Outdated Show resolved Hide resolved
@driss-chelouati driss-chelouati changed the title feat: handle message create message plugin component Jul 10, 2023
Copy link
Contributor

@driss-chelouati driss-chelouati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a problem with message spacing at the start, please review the UI here:
https://github.com/shuriken-ui/website/tree/main/shuriken-ui/elements/messages

Looks like this:
test

Should look like this:
test-ok

@driss-chelouati driss-chelouati changed the title create message plugin component feat: create message plugin component Jul 10, 2023
@driss-chelouati
Copy link
Contributor

Fix icon sizes

@stafyniaksacha stafyniaksacha merged commit 8df0df4 into main Jul 23, 2023
@stafyniaksacha stafyniaksacha deleted the feat/message branch July 23, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants