Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement to csproj #1

Closed
JulianBirch opened this issue Oct 15, 2022 · 2 comments
Closed

Improvement to csproj #1

JulianBirch opened this issue Oct 15, 2022 · 2 comments

Comments

@JulianBirch
Copy link

JulianBirch commented Oct 15, 2022

I'd just like to thank you for publishing this. Whilst I'm not using the code directly, it's proved an invaluable guide the less documented aspects of developing a source generator. I did, however, find a slightly better solution to the dll packaging issues, (not mine: @Turnerj posted it on dotnet/roslyn#52017)

  <PropertyGroup>
    
<GetTargetPathDependsOn>$(GetTargetPathDependsOn);GetDependencyTargetPaths</GetTargetPathDependsOn>
  </PropertyGroup>

  <Target Name="GetDependencyTargetPaths" AfterTargets="ResolvePackageDependenciesForBuild">
    <ItemGroup>
      <TargetPathWithTargetPlatformMoniker Include="@(ResolvedCompileFileDefinitions)" IncludeRuntimeDependency="false" />
    </ItemGroup>
  </Target>

Anyway, this isn't much of an issue, more of a thank you.

@shuebner
Copy link
Owner

Hi Julian,
thank you for your kind words. I am glad this proof-of-concept could be of help. That was all I was hoping for :-)

Also thank you for the better solution. I try to remember it on the next source generator that uses external libraries.

@JulianBirch
Copy link
Author

Actually, it turns out the "better solution" isn't stable. So maybe give it a miss. The original issue has some other proposed solutions though, so I'll try those out sometime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants