Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update homepage UI #14

Closed
rjayroso opened this issue Oct 16, 2020 · 2 comments
Closed

Update homepage UI #14

rjayroso opened this issue Oct 16, 2020 · 2 comments

Comments

@rjayroso
Copy link

Hey, I 'm interested in your project and I was wondering if you want to upgrade your homepage UI. The MaterialApp at the top looks like a search bar instead of a navigation bar which might confuse some users into thinking that the whole thing is clickable. My solution is to use an appBar that displays the app's title "Covid World Stats" and a clickable search bar that calls your _showPickerModal(context, viewModel) function instead of clicking the tiny search icon.

Let me know what you think, thanks!

@silviorp
Copy link
Owner

I haven't included the appBar in the app to bring a modern UI and to avoid it to have an Android UI, since the intention is to have it working both on Android and iOS. Also, I'm seeing a move from using the default Android appBar in most of the modern apps and I think that's happening because it looks too outdated.

I think removing the rounded rectangular background would be enough to eliminate the feel of a search bar from the top of the app. What do you think?

@rjayroso
Copy link
Author

Oh I see what you were going for, and I totally agree now. Mind if I commit another to my PR and update it to keep the original design but remove the rounding?

That being said, I still think you may need to display the country name at the top along with the flag since the title "Covid World Stats" for stats relating to only one country might be a little confusing. What do you think? Keep the title or make it dynamic in line with the country?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants