Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaSinkSingle: make transform validation fail when kafka port == shotover port #1370

Open
rukai opened this issue Nov 20, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@rukai
Copy link
Member

rukai commented Nov 20, 2023

It should fail with a message like:

KafkaSinkSingle:
  the destination_port is the same as the port used by `KafkaSource`. These ports must be unique as shotover and the destination kafka must be behind the same IP and therefore cannot share a port.

In order to implement this validation we will need to extend our transform validation infrastructure to pass in the TransformChainBuilder to the TransformBuilder::validate method so each transform may perform analysis on the rest of the chain.

@rukai
Copy link
Member Author

rukai commented May 30, 2024

Since I originally wrote KafkaSinkSingle I've learnt that kafka has a far stronger distinction between advertised address and real address compared to cassandra.
So I think maybe the whole approach of including rewriting in the transform might have been a mistake.
Maybe we should just have kafka advertise shotover's address instead.

@rukai rukai added the bug Something isn't working label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant