-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static plugins improvement #4990
Static plugins improvement #4990
Conversation
|
@shyim then...why not considering to include "custom/static-plugins" directory in PluginFinder and KernelPluginLoader? Or it just do within another way? |
tests/unit/Core/Framework/Plugin/Command/PluginCreateCommandTest.php
Outdated
Show resolved
Hide resolved
59f51c3
to
fe55835
Compare
@raffaelecarelle static-plugins are intended to be loaded by Composer. Therefore, they are not considered manually |
as I thought...But I think this change it would help anyway to create plugins or themes easier :) feedback are welcome. thankyou! |
As the So I think as long as the |
@@ -30,13 +30,15 @@ public function __construct(private readonly string $projectDir) | |||
protected function configure(): void | |||
{ | |||
$this | |||
->addArgument('theme-name', InputArgument::OPTIONAL, 'Theme name'); | |||
->addArgument('theme-name', InputArgument::OPTIONAL, 'Theme name') | |||
->addOption('static', null, null, 'Create Theme in custom/static-plugins folder'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
->addOption('static', null, null, 'Create Theme in custom/static-plugins folder'); | |
->addOption('static', null, null, 'Theme will be created in the static-plugins folder'); |
I think that too. Thank you |
Thanks for the improvement @raffaelecarelle 🎉 |
1. Why is this change necessary?
Easiest scafolding for project related plugin
2. What does this change do, exactly?
5. Checklist