SQL Value marshall/unmarshall is broken

[risentveber]

Get error when used with gorm:

pq: encode: unknown type for decimal.Decimal

All nice on commit: cd690d0
but broken for the last one: a36b5d8

Also, it would be nice if you will add go mod support.

[risentveber]

➜  decimal git:(master) git diff cd690d0..a36b5d8 --name-only | cat
.travis.yml
decomposer.go
decomposer_test.go

seems like something is wrong in decomposer.go file

[risentveber]

See also golang/go#34315

[njason]

commit 75bb2cb has been reverted from master and will be worked on in another branch

[risentveber]

@njason maybe it's time to add go modules with versioning?

[mwoss]

@risentveber We will do it in our next iteration. Stay tuned

[andskor]

@mwoss any update?

[mwoss]

I've tried to recall where our discussion with Jason ended on that, but I'm not quite sure. I have a vague memory that we were waiting for the response from lib/pq maintainers, but I could be wrong. @njason could you elaborate?

[njason]

Using the decomposer-interface branch, which contains the PR that was previously reverted from master, I am still able to reproduce the encoding issue (with go 1.13, latest version of lib/pq). The issue is occurring because this encode function in lib/pq does not support the shopspring Decimal type. @kardianos made a suggestion for a solution that would require database drivers to recognize the decomposer type.

I believe this issue should be closed since SQL value marshalling is no longer broken on master. For now, we can keep the decomposer-interface branch and continue to work with the go community to support the decomposer interface when possible.

[mwoss]

Thanks for the detailed explanation, Jason :D
Let's wait for a couple of days before closing the issue, so @andskor and @risentveber will be able to respond to it.

[risentveber]

@mwoss yeah you can close - tnanks)