Spanish translation

[OlgaMorales]

No description provided.

[amaury1093]

Thank you! I'll have a look tonight

[amaury1093]

Thanks a lot for this PR! It looks overall really good, I just tried in the app, there are only 2-3 places where the text is a bit long.

[amaury1093]

Is .! a typo?

[amaury1093]

On smaller screens, this text goes on 2 lines. Would it be possible to find a shorter variant?

[amaury1093]

This text is slightly too long, can we make it a bit shorter? We could either use Faq, or Acerca de

[OlgaMorales]

Sure! I'll make some modifications.

…

On Wed, 24 Apr 2019, 08:52 Amaury Martiny, ***@***.***> wrote: ***@***.**** commented on this pull request. Thanks a lot for this PR! It looks overall really good, I just tried in the app, there are only 2-3 places where the text is a bit long. ------------------------------ In App/localization/languages/es.json <#79 (comment)> : > + "details_air_quality_station_marker": "Estación de calidad del aire", + "details_your_position_marker": "Tu posición", + "details_header_latest_update_label": "Última actualización:", + "details_header_primary_pollutant_label": "Contaminante primario:", + "details_distance_label": "Estación AQI: {{distanceToStation}}km de distancia", + "about_how_do_you_calculate_the_number_of_cigarettes_title": "¿Cómo se calcula el número de cigarrillos?", + "about_how_do_you_calculate_the_number_of_cigarettes_message_1": "Esta aplicación se inspiró en los hallazgos de Berkeley Earth sobre la", + "about_how_do_you_calculate_the_number_of_cigarettes_link_1": "Equivalencia entre la contaminación del aire y el tabaquismo.", + "about_how_do_you_calculate_the_number_of_cigarettes_message_2": ". La regla de oro es simple: un cigarrillo por día es el equivalente aproximado de un nivel de PM2.5 de 22", + "about_where_does_data_come_from_title": "¿De dónde vienen los datos?", + "about_where_does_data_come_from_message_1": "Los datos de calidad del aire provienen de", + "about_where_does_data_come_from_link_1": "WAQI", + "about_were_does_data_come_from_message_2": "en la forma de niveles de PM2.5 AQI que generalmente se actualizan cada hora y se convierten en niveles directos de PM2.5 mediante la aplicación", + "about_why_is_the_station_so_far_title": "¿Por qué la estación está tan lejos de mi ubicación actual?", + "about_why_is_the_station_so_far_message": "Dado que las estaciones que miden y comunican los resultados de la calidad del aire cada hora son costosas, los datos aún se limitan a regiones bien desarrolladas y ciudades más grandes de todo el mundo. Si está lejos de un centro urbano más prominente, los resultados probablemente no serán tan precisos. Lo más probable es que su aire sea mejor en ese caso al menos!", + "about_weird_results_title": "Los resultados son extraños o inconsistentes con otras fuentes.!", Is .! a typo? ------------------------------ In App/localization/languages/es.json <#79 (comment)> : > @@ -0,0 +1,52 @@ +{ + "error_screen_common_sorry": "Disculpa!\n", + "error_screen_error_cannot_load_cigarettes": "No logramos\ncargar tus\ncigarrillos.", + "error_screen_choose_other_location": "Elige otra ubicación", + "error_screen_error_description": "Existe un problema con nuestra base de datos, o no existen estaciones de monitoreo de aire cerca. Intente más tarde ", + "error_screen_error_message": "Error: {{errorText}}", + "home_station_too_far_message": "No logramos encontrar una estación cercana.\nLos resultados pueden ser inexactos a esta distancia.", + "home_share_title": "¿Sabía que puede estar fumando hasta 20 cigarrillos por día, solo por vivir en una gran ciudad?", + "home_share_message": "Maldición! 'hoy fumé'' {{cigarettes}} cigarrillos respirando el aire urbano. ¿Y tú? Encuentralo aquí: https://shootismoke.github.io", + "home_header_air_quality_station_distance": "Estación de calidad del aire: {{distanceToStation}}km de distancia", + "home_btn_why_is_station_so_far": "¿Por qué la estación está tan lejos??", + "home_btn_see_detailed_info": "Ver informacion detallada", On smaller screens, this text goes on 2 lines. Would it be possible to find a shorter variant? ------------------------------ In App/localization/languages/es.json <#79 (comment)> : > @@ -0,0 +1,52 @@ +{ + "error_screen_common_sorry": "Disculpa!\n", + "error_screen_error_cannot_load_cigarettes": "No logramos\ncargar tus\ncigarrillos.", + "error_screen_choose_other_location": "Elige otra ubicación", + "error_screen_error_description": "Existe un problema con nuestra base de datos, o no existen estaciones de monitoreo de aire cerca. Intente más tarde ", + "error_screen_error_message": "Error: {{errorText}}", + "home_station_too_far_message": "No logramos encontrar una estación cercana.\nLos resultados pueden ser inexactos a esta distancia.", + "home_share_title": "¿Sabía que puede estar fumando hasta 20 cigarrillos por día, solo por vivir en una gran ciudad?", + "home_share_message": "Maldición! 'hoy fumé'' {{cigarettes}} cigarrillos respirando el aire urbano. ¿Y tú? Encuentralo aquí: https://shootismoke.github.io", + "home_header_air_quality_station_distance": "Estación de calidad del aire: {{distanceToStation}}km de distancia", + "home_btn_why_is_station_so_far": "¿Por qué la estación está tan lejos??", + "home_btn_see_detailed_info": "Ver informacion detallada", + "home_btn_more_details": "Más detalles", + "home_btn_faq_about": "Faq/Acerca de", This text is slightly too long, can we make it a bit shorter? We could either use Faq, or Acerca de — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#79 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALQAHMINLHPLWPCMR7PC5FLPSBQ3VANCNFSM4HH6ZUTQ> .

[OlgaMorales]

I tried to see the changes locally, but I couldn't open the app, I followed the steps which are in the doc. However,
it was showed only one picture once started the project.

[lucienbl]

Hey @OlgaMorales ! Did you create a config file from the template and replaced the API field with your own key? Can you send the log?

[OlgaMorales]

hi @lucienbl where that file should be created? I just modified the the app.json file where I put my own tokens, but as I could not see my local changes then I tried it on expo staging release channel, could you guide me please?

[lucienbl]

Hey @OlgaMorales , why couldn't you see your local changes? 🤔 The app.json is right, you have to create this file and add your tokens there. Once you've done this just run yarn && yarn start which should start the development server. Then on your device download the "Expo" app from the Play Store and flash the QR code from your console 😉

Edit: make sure you've installed yarn on your computer

[OlgaMorales]

@lucienbl you are right I was trying another way, however if i have my phone with Spanish language as default is it not supposed that should I see everything in Spanish ?, as I see it in English yet.

[lucienbl]

@OlgaMorales wait for merging, pull again and restart app 😉

[amaury1093]

@OlgaMorales Thanks for this PR! I just integrated your Spanish translations, if you git checkout master && git pull and re-run the app, it should show it in Spanish. Please tell us if it still doesn't work 🙏