-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Towards better xvalidation #4334
Comments
@vinx13 this is for you. Note: this is for later, no need to start doing this now. Just wrote it down since I just had a look at the code |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@karlnapf do you know how much of this is still relevant? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I think quite some stuff has been done, so closing. |
Introduce iterator interface for pairs of train/validation indices in
CSplittingStrategy
Remove
CFeatures
training data fromCMachine
stateRemove
CLabels
training data fromCMachine
stateWhile the above two are being worked on, we could have a
CMachine::clone_without_data
that allows to clone a machine without cloning the data as well, to be used in xvalidation code.Introduce
CMachine::train(CFeatures*, CLabels*)
(user API)If possible, introduce
CMachine::train(const CFeatures*, const CLabels*)
, via propagating constness in downstream calls. The above user API call would be a wrapper that just calls this method eventually.Introduce a view for features, in the lines of `CFeatures* CFeatures::subset(SGVector,index_t>), that returns a new instance with an active subset, but the same underlying data (no copy)
Same view for
CLabels
Rewrite x-validation
The text was updated successfully, but these errors were encountered: