Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons in Icon browser on shoelace.style in Dark Mode: Black on Black #578

Closed
oliveratgithub opened this issue Nov 5, 2021 · 2 comments
Closed

Icons in Icon browser on shoelace.style in Dark Mode: Black on Black #578

oliveratgithub opened this issue Nov 5, 2021 · 2 comments
Assignees
@claviska
Labels
bug Things that aren't working right in the library.

Comments

@oliveratgithub
Copy link

Describe the bug

The icon browser on the «Icons» page on https://shoelace.style are hard to read when dark mode is on. Almost black on black.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://shoelace.style
  2. Enable «Dark Mode»
  3. Click on the «Icons» page
  4. Scroll down to the icon browser
  5. See that the icons are hard to read due to the contrast

Browser / OS

  • OS: macOS 15
  • Browser Safari 15
@oliveratgithub oliveratgithub added the bug Things that aren't working right in the library. label Nov 5, 2021
@claviska
Copy link
Member

claviska commented Nov 5, 2021

Thanks for reporting this. Quick fix, just in time for the next release! 😅

@oliveratgithub
Copy link
Author

A pleasure to my eyes now 👀👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@claviska claviska

Labels
bug Things that aren't working right in the library.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@claviska @oliveratgithub