Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<sl-input type="password"> and edge's built-in reveal button #508

Closed
ajmchambers opened this issue Aug 22, 2021 · 1 comment
Closed

<sl-input type="password"> and edge's built-in reveal button #508

ajmchambers opened this issue Aug 22, 2021 · 1 comment
Assignees
Labels
bug Things that aren't working right in the library.

Comments

@ajmchambers
Copy link
Contributor

Describe the bug
Edges built-in password reveal icon is displayed on <sl-input type="password"> in edge, also if using the toggle-password attribute you will end up with both icons displayed.

Expected behavior
Might be best to always disable edge's reveal icon and rely on the toggle-password attribute like on other browsers.

Alternatively, the toggle-password could be used to enable edge's default reveal control, and instead customize it's colour to fit shoelace's theme (however the built-in button behaves differently).

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Edge (chromium)
  • Version: 92.0.902.78 (Official build) (64-bit)

Additional context
Here is a link to the edge docs describing about it:
https://docs.microsoft.com/en-us/microsoft-edge/web-platform/password-reveal

Can be hidden like this:

::-ms-reveal {
    display: none;
}

Alternatively the native icon can be styled like this:

::-ms-reveal {
    border: 1px solid transparent;
    border-radius: 50%;
    box-shadow: 0 0 3px currentColor;
}
@ajmchambers ajmchambers added the bug Things that aren't working right in the library. label Aug 22, 2021
@claviska
Copy link
Member

Thanks for reporting this. It seems to only happen on Windows, as Edge for Mac doesn't show a toggle. I've opted to hide the system one for a consistent DX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things that aren't working right in the library.
Projects
None yet
Development

No branches or pull requests

2 participants