Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move files into top level directory from fortune-mod/ #10

Closed
jeffsheltren opened this issue Jun 27, 2017 · 6 comments
Closed

Move files into top level directory from fortune-mod/ #10

jeffsheltren opened this issue Jun 27, 2017 · 6 comments

Comments

@jeffsheltren
Copy link
Contributor

I'm not sure why this repo has a sub directory fortune-mod instead of having all of those files at the top level of the repo. It would be cleaner to move all those files to the top level of the repo.

@shlomif
Copy link
Owner

shlomif commented Jun 28, 2017

Hi @jeffsheltren !

I prefer to have a sub-dir so I can later on create other sub dirs that won't be part of the main source distro and won't be reachable to cmake / cpack / etc. . For an example of that, see https://github.com/shlomif/fc-solve . Can I close this issue?

@jeffsheltren
Copy link
Contributor Author

As it is now, un-taring a release will give e.g. fortune-mod-fortune-mod-1.99.5/fortune-mod which isn't very clean, and definitely isn't standard or what was done in previous "upstream" releases. I'm looking at packaging this for Fedora and think it makes more sense to drop the extra sub-directory. I'm not clear how/why this affects cmake, etc.

@shlomif
Copy link
Owner

shlomif commented Jun 28, 2017 via email

@shlomif
Copy link
Owner

shlomif commented Jul 11, 2017

@jeffsheltren : hi! Did you get my last message? Please reply.

@shlomif
Copy link
Owner

shlomif commented Jul 14, 2017

@jeffsheltren : ping.

@shlomif
Copy link
Owner

shlomif commented Jul 28, 2017

I'm closing this issue because I think it was addressed in the comments and because @jeffsheltren has been unresponsive for several weeks. If there's need, I will reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants