Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaultViewContainer does not exist in ngx-modialog 3.x and higher #438

Open
beli3v3inm3 opened this issue Jun 5, 2018 · 1 comment
Open

Comments

@beli3v3inm3
Copy link

IMPORTANT: Please provide a sample using: http://plnkr.co/edit/lV7zsw7Yqossgs9JOfQU?p=preview

  • I'm submitting a ...
    [*] bug report
    [ ] feature request
    [ ] question about the decisions made in the repository

  • Do you want to request a feature or report a bug?
    Bug

  • What is the current behavior?
    After migrating to ngx-modialog 3.x.x and higher there is no present 'defaultViewContainer' in Overlay and Modal providers.

  • If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via
    https://plnkr.co or similar (you can use one of the templates above as a starting point).
    Angular 4 with version 3.x
    Angular 5 with version 5.x

  • What is the expected behavior?
    Should opening modal

  • What is the motivation / use case for changing the behavior?
    n/a

  • Please tell us about your environment:

  • Angular version: 4.4.7
  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)
@greg73
Copy link

greg73 commented Jul 18, 2018

You don't need it.
Are you using Bootstrap 3? If so you need to call bootstrap3Mode()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants