Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Documentation link opens site in child window. #437

Open
Codewizard opened this issue May 30, 2018 · 0 comments
Open

Site Documentation link opens site in child window. #437

Codewizard opened this issue May 30, 2018 · 0 comments

Comments

@Codewizard
Copy link

Codewizard commented May 30, 2018

IMPORTANT: Please provide a sample using: http://plnkr.co/edit/lV7zsw7Yqossgs9JOfQU?p=preview

  • I'm submitting a ...
    [ X] bug report
    [ ] feature request
    [ ] question about the decisions made in the repository

  • Do you want to request a feature or report a bug?
    Bug

  • What is the current behavior?

  1. Navigate to the website http://shlomiassaf.github.io/ngx-modialog/#/home
  2. Click Documentation
  3. fill site opens in child frame.

also your plunker examples are all still broken in chrome.

  • If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via
    https://plnkr.co or similar (you can use one of the templates above as a starting point).
  1. Navigate to the website http://shlomiassaf.github.io/ngx-modialog/#/home
  2. Click Documentation
  3. full site opens in child frame.
  • What is the expected behavior?
    That the documentation is available.

  • What is the motivation / use case for changing the behavior?
    So users can view documentation.

  • Please tell us about your environment:

  • Angular version: ? N/A
  • Browser: [all | Chrome x | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant