Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to league/uri 7.0 #1988

Closed
acelaya opened this issue Feb 4, 2024 · 0 comments · Fixed by #1991
Closed

Update to league/uri 7.0 #1988

acelaya opened this issue Feb 4, 2024 · 0 comments · Fixed by #1991
Milestone

Comments

@acelaya
Copy link
Member

acelaya commented Feb 4, 2024

The main incompatibility to update is that NotFoundRedirectResolver uses this to parse a URL that can originally contain placeholders.

v6 does not URL-encode the placeholders when present in the path, but v7 does, so the logic needs to be adjusted.

However, this logic was probably wrong in v6, as other psr-compatible URL parsers behave like v7 (that's probably why this library was introduced int the first place, as other libs are already a dependency and could have been used instead).

An alternative would be to stop using league/uri entirely if the logic can be refactored to work with any of the other dependencies.

@acelaya acelaya added this to the 4.0.0 milestone Feb 4, 2024
@acelaya acelaya added this to Shlink Feb 4, 2024
@acelaya acelaya moved this to In Progress in Shlink Feb 5, 2024
@acelaya acelaya moved this from In Progress to In review in Shlink Feb 5, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Shlink Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant