Possible TypeScript type definitions regression on 1.2.3

[AlexTMjugador]

Hi, thanks for your work on this useful Pagefind integration for Astro!

I use it in an open-source project where Renovate automatically updates dependencies, and as a result I have noticed that bumping astro-pagefind from 1.2.3 to 1.2.3 caused some new TypeScript checking errors, which you can read in this CI workflow run log.

Since this is a patch release, there should not be any breaking changes like this. As far as I know, my project isn't doing anything wrong with how it integrates astro-pagefind, but I'd love to hear if I'm wrong or should change something on my end.

[shishkin]

Thanks for reporting the issue. I'm sorry that the latest release, which intended to fix previous TypeScript issue (#29), introduced new ones.

What you observe seem to relate to the issue I tried to fix upstream in astro. Although I'm not clear why it builds in this repo's example Astro project.

[AlexTMjugador]

That's interesting to know, thanks! I'm afraid I don't have enough bandwidth to meaningfully help resolving the issue you linked to, but I'm willing to give feedback otherwise. I can stay on 1.2.2 for a little while.

[akyag]

@shishkin Hello, thanks for working on bringing Pagefind to Astro, This is my first time using it and I am pretty excited to finally have a search for a static website. Once your PR gets merged, this will be fixed right? I can help with testing. Also if I used the previous version, is that currently working?

Edit: I tried the 1.2.2 and it's working. How do I pass arguments like --bundle-dir mysearch for example. Need that for using GitHub pages as a host.

[shishkin]

@AlexTMjugador do you still see the issue after upgrading Astro to 2.10.8?

[shishkin]

How do I pass arguments like --bundle-dir mysearch for example. Need that for using GitHub pages as a host.

@akyag You should not need to change pagefind's bundle dir for that. Take a look at this Astro guide.

[AlexTMjugador]

@AlexTMjugador do you still see the issue after upgrading Astro to 2.10.8?

Yes, the problem still occurs with Astro 2.10.8 and later. Specifically, I tested with 2.10.15. The errors haven't changed for me since I reported this issue.

Edit: I tested with the astro-pagefind 1.2.3 release and not with the latest commits, however. Let's see what happens if I patch astro-pagefind to use the latest code.

Edit 2: it doesn't work even if I use the latest astro-pagefind package sources.

[AlexTMjugador]

Updating Astro to 3.1.0 fixed this issue for me 🎉

[shishkin]

Thanks for confirming. I'll close the issue then.