Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does shipwright support access to Github with token? #968

Closed
wanjunlei opened this issue Dec 22, 2021 · 5 comments · Fixed by #1117
Closed

Does shipwright support access to Github with token? #968

wanjunlei opened this issue Dec 22, 2021 · 5 comments · Fixed by #1117
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. hacktoberfest Hacktoberfest Candidate Issues kind/documentation Categorizes issue or PR as related to documentation.

Comments

@wanjunlei
Copy link
Contributor

I am using shipwright v0.7.0 to build Github's private repository. I created a secret containing username and password, and then the step-source-default reported the following error:

remote: Support for password authentication was removed on August 13, 2021. Please use a personal access token instead.

 remote: Please see https://github.blog/2020-12-15-token-authentication-requirements-for-git-operations/ for more information.

 fatal: Authentication failed for 'https://github.com/kubesphere/kube-auditing.git/' (exit code 128)

Then I create a secret include token, the step-source-default reported the following error:

Unsupported type of credentials provided, either SSH private key or username/password is supported (exit code 110)

Does shipwright support access to Github with tokens? How should I configure the secret?

@SaschaSchwarze0
Copy link
Member

Hi @wanjunlei, thank you for the feedback. I think you would create a basic-auth kubernetes secret like you did before with username and password, and you now take the personal access token as password. But, something we have not yet tested. But, also something that we should get into our documentation given this is a common scenario.

If you can try with the personal access token as password and give us feedback if it works, that would be nice.

@adambkaplan
Copy link
Member

I think you would create a basic-auth kubernetes secret like you did before with username and password, and you now take the personal access token as password.

I believe this is the correct answer - we have documentation in the build repository on how to do this: https://github.com/shipwright-io/build/blob/main/docs/development/authentication.md#basic-authentication

@adambkaplan adambkaplan added the triage/support Indicates an issue that is a support question. label Jan 12, 2022
@adambkaplan
Copy link
Member

/assign @adambkaplan

@wanjunlei
Copy link
Contributor Author

Thanks for your replies, I will try this.

@SaschaSchwarze0 SaschaSchwarze0 added kind/documentation Categorizes issue or PR as related to documentation. and removed triage/support Indicates an issue that is a support question. labels Mar 9, 2022
@SaschaSchwarze0
Copy link
Member

From grooming: we will enhance the documentation to mention that repositories move away from password support towards token support instead, and link to the token documentation of the popular providers (GitHub, GitLab).

@SaschaSchwarze0 SaschaSchwarze0 added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Mar 9, 2022
@adambkaplan adambkaplan added the hacktoberfest Hacktoberfest Candidate Issues label Sep 28, 2022
Repository owner moved this from Todo to Done in Hacktoberfest 2022 Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. hacktoberfest Hacktoberfest Candidate Issues kind/documentation Categorizes issue or PR as related to documentation.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants