Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cancelling running/in flight BuildRun #54

Closed
gabemontero opened this issue Mar 4, 2020 · 3 comments · Fixed by #809
Closed

cancelling running/in flight BuildRun #54

gabemontero opened this issue Mar 4, 2020 · 3 comments · Fixed by #809
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@gabemontero
Copy link
Member

openshift build v1 allows for cancelling in progress builds via the CLI and REST

tekton cli can also cancel in progress taskruns and pipelineruns

build v2 should tie in a cancel function (assuming it already plans on a start build function) to oc

and where possible, if it makes sense to vendor in tkn code into oc to facilitate things, by all means

@gabemontero gabemontero added the buildv1 Items with this label somehow pertain to getting equivalent buildv1 function in buildv2 label Mar 9, 2020
@adambkaplan adambkaplan changed the title cancelling running/in flight build v2 cancelling running/in flight BuildRun Oct 29, 2020
@adambkaplan adambkaplan added this to the Post GA Backlog milestone Oct 29, 2020
@adambkaplan
Copy link
Member

This isn't a minimum viable feature, but worth pursuing in the long run. Since we use Tekton TaskRun objects under the covers, it's possible to indirectly cancel a BuildRun by cancelling the underlying TaksRun via the tkn command line.

@adambkaplan adambkaplan added kind/feature Categorizes issue or PR as related to a new feature. and removed buildv1 Items with this label somehow pertain to getting equivalent buildv1 function in buildv2 labels Oct 29, 2020
@zhangtbj
Copy link
Contributor

Yes, Tekton supports it natively.

But it should also need to server side implementation, like the introduction on Tekton side:
https://github.com/tektoncd/pipeline/blob/master/docs/taskruns.md#cancelling-a-taskrun

spec:
  # […]
  status: "TaskRunCancelled"

We should be able to allow add a status like abouve in buildrun to cancel a buildrun OR we may have a logic in our controller to add the taskrun status TaskRunCancelled for the buildrun's taskrun

@qu1queee
Copy link
Contributor

We should have this! danke!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants