specify labels to be set on output images

[gabemontero]

Today in openshift build v1 one can specify labels to set on the resulting output image.

Do we want to replicate such a capability in the build v2 API?

In theory such labels could be propagated as tekton parameters to the various steps in a task, where the steps that produce/push the image could leverage the options of the build tool being leveraged to set the label.

[sbose78]

Yes, we should have this.

[zhangtbj]

Hi all,

Do you mean set the specify labels on the resulting output ImageStream or the real output Docker image?

[gabemontero]

Hi all,

Do you mean set the specify labels on the resulting output ImageStream or the real output Docker image?

On the image ... not the imagestream

[adambkaplan]

/kind feature

This is perhaps something we add to the output image spec in the API. Controlling labels on images is an important feature in multiple DevOps contexts.

Each build strategy would probably need to implement this on their own terms, and accept the labels array/map as an argument.

[otaviof]

As a example use-case, we can consider new GitHub Container Registry it needs labels to link the image with the project/organization.

[akram]

Hi @gabemontero and @otaviof,

it looks like to be done here: https://github.com/shipwright-io/build/blob/master/pkg/controller/buildrun/runtime_image.go#L35-L37

isnt'it ?

[gabemontero]

Hi @gabemontero and @otaviof,

it looks like to be done here: https://github.com/shipwright-io/build/blob/master/pkg/controller/buildrun/runtime_image.go#L35-L37

isnt'it ?

Yeah @akram that copies labels from the runtime / base / builder image to the output image.

But this feature request, which is one of the "port openshift build functionality to shipwright" types, is to also be able to specify labels on the build, independent of the runtime image used, and have those show up on the output image.

That said, I believe what you pointed out is a useful distinction, and if / when we do this particular feature, the associated doc should explicitly distinguish between the two.

thanks

[SaschaSchwarze0]

Related EP: Add EP: Modifying Output Image #731