Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inject source via config map / secrets feature #48

Open
gabemontero opened this issue Mar 4, 2020 · 7 comments
Open

inject source via config map / secrets feature #48

gabemontero opened this issue Mar 4, 2020 · 7 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@gabemontero
Copy link
Member

gabemontero commented Mar 4, 2020

Today openshift build v1 API allows for injection of config map content under the source tree of the build container for use during the image build

Do we want to expose a similar policy in build v2?

tekton tasks already allow for mounting of config maps / secret volumes in tasks/taskruns

@gabemontero gabemontero changed the title inject source via config map feature inject source via config map / secrets feature Mar 4, 2020
@gabemontero gabemontero added the buildv1 Items with this label somehow pertain to getting equivalent buildv1 function in buildv2 label Mar 9, 2020
@sbose78
Copy link
Member

sbose78 commented Mar 12, 2020

Today openshift build v1 API allows for injection of config map content under the source tree

Could you help me with a scenario, please?

@gabemontero
Copy link
Member Author

Today openshift build v1 API allows for injection of config map content under the source tree

Could you help me with a scenario, please?

In this case I think our docs do a sufficient job of capturing this one. See https://docs.openshift.com/container-platform/4.3/builds/creating-build-inputs.html#builds-input-secrets-configmaps_creating-build-inputs

@otaviof
Copy link
Member

otaviof commented Mar 18, 2020

Interesting use-case, @gabemontero. Putting myself as a final user, it would come handy to share common resources between different builds, therefore, it would act as another point of extensibility, which currently we only offer on BuildStrategy.

Good idea, I think we should pursue it!

@adambkaplan
Copy link
Member

/kind feature

This would be useful in two contexts - dovetailing on the discussion in #419:

  1. Using ConfigMap and Secrets as content in the image to be built (sources)
  2. Using ConfigMap and Secrets as supplemental information used in the build, but is not present in the final image (volumes)

@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 22, 2020
@sbose78 sbose78 added this to the Post GA Backlog milestone Oct 22, 2020
@adambkaplan adambkaplan removed the buildv1 Items with this label somehow pertain to getting equivalent buildv1 function in buildv2 label Oct 22, 2020
@qu1queee qu1queee added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jan 15, 2021
@gabemontero
Copy link
Member Author

@adambkaplan I feel like we can either close this in favor of shipwright-io/community#23 and any items opened as a result of that, or we should cite this issue as something address by that SHIP,

The former feels better but I'm enough on the fence to not hit the close button unilaterally

Thoughts?

@adambkaplan
Copy link
Member

There are a few subtle differences:

  • SHIP-0022's objective is to let strategy authors define volumes that could be optionally altered by the developer.
  • We don't have a SHIP yet that lets developers arbitrarily mount Secrets or ConfigMaps into a Build/BuildRun. That is a logical follow-up to SHIP-0022.

@gabemontero
Copy link
Member Author

There are a few subtle differences:

* SHIP-0022's objective is to let strategy authors define volumes that could be optionally altered by the developer.

* We don't have a SHIP yet that lets developers arbitrarily mount Secrets or ConfigMaps into a Build/BuildRun. That is a logical follow-up to SHIP-0022.

I'm not sure how the existing API or new api proposed in https://github.com/shipwright-io/community/blob/32b3d0f8f802d98a605bc2670fe2094229bdbb98/ships/0022-build-strategy-volumes.md would change based on your 2 points ^^

I have a guess or two perhaps, but instead, would it be feasible to construct yaml tweaks to either existing API or you proposed API to make it clear what you are getting at ?

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

6 participants