From 62930cdeea3b1f23439ddcf7fd820795a7e2d280 Mon Sep 17 00:00:00 2001 From: Brendan Forster Date: Sun, 31 Mar 2024 14:26:12 -0300 Subject: [PATCH] bump electron to latest v28 release (#1035) --- app/.npmrc | 2 +- package.json | 2 +- script/validate-electron-version.ts | 4 ++-- yarn.lock | 8 ++++---- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/app/.npmrc b/app/.npmrc index 104a19e8335..137b0270b55 100644 --- a/app/.npmrc +++ b/app/.npmrc @@ -1,3 +1,3 @@ runtime = electron disturl = https://electronjs.org/headers -target = 26.2.4 +target = 28.2.9 diff --git a/package.json b/package.json index 9603281379a..2173b02a618 100644 --- a/package.json +++ b/package.json @@ -159,7 +159,7 @@ "@types/webpack-hot-middleware": "^2.25.6", "@types/webpack-merge": "^5.0.0", "@types/xml2js": "^0.4.11", - "electron": "28.2.3", + "electron": "28.2.9", "electron-builder": "^24.13.3", "electron-packager": "^17.1.2", "eslint-plugin-github": "^4.10.1", diff --git a/script/validate-electron-version.ts b/script/validate-electron-version.ts index cd8fef88945..473fe22bf3e 100644 --- a/script/validate-electron-version.ts +++ b/script/validate-electron-version.ts @@ -15,8 +15,8 @@ type ChannelToValidate = 'production' | 'beta' * to a previous version of GitHub Desktop without losing all settings. */ const ValidElectronVersions: Record = { - production: '28.2.3', - beta: '28.2.3', + production: '28.2.9', + beta: '28.2.9', } const channel = diff --git a/yarn.lock b/yarn.lock index e5c0fdcc693..24c5ce1862a 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3990,10 +3990,10 @@ electron-winstaller@*, electron-winstaller@^5.0.0: lodash.template "^4.2.2" temp "^0.9.0" -electron@28.2.3: - version "28.2.3" - resolved "https://registry.yarnpkg.com/electron/-/electron-28.2.3.tgz#d26821bcfda7ee445b4b75231da4b057a7ce6e7b" - integrity sha512-he9nGphZo03ejDjYBXpmFVw0KBKogXvR2tYxE4dyYvnfw42uaFIBFrwGeenvqoEOfheJfcI0u4rFG6h3QxDwnA== +electron@28.2.9: + version "28.2.9" + resolved "https://registry.yarnpkg.com/electron/-/electron-28.2.9.tgz#7c94a4901b1cb40993906f060a14a108039ac817" + integrity sha512-6b6G6jq4ypKxdCRNjULmqWEott4GJe2kaAykLonaTaeFqoFFHbzOu4k6pAzurseFhv452aUob9DAH6eI7UlOUw== dependencies: "@electron/get" "^2.0.0" "@types/node" "^18.11.18"