Skip to content
This repository has been archived by the owner on Dec 17, 2023. It is now read-only.

sufi - Chainlink registry not available on arbitrum & optimism #183

Closed
sherlock-admin opened this issue Jun 11, 2023 · 0 comments
Closed
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label Medium A valid Medium severity issue Reward A payout will be made for this issue

Comments

@sherlock-admin
Copy link
Contributor

sherlock-admin commented Jun 11, 2023

sufi

high

Chainlink registry not available on arbitrum & optimism

Summary

The price oracle of the protocol relies on using the chainlink registry to fetch asset prices. According to chainlink docs the registry is currently only available on mainnet.

Vulnerability Detail

The price oracle contract will not be able to register any feeds on arbitrum or optimism due to unavailability of a chainlink registry on both the chains.

https://docs.chain.link/data-feeds/feed-registry#contract-addresses

Impact

Due to a lack of a registry from chainlink on arbitrum and optimism the price oracle contract will render itself useless as it won't be able to register any new feeds and hence not return price for any assets.

Code Snippet

https://github.com/sherlock-audit/2023-05-ironbank/blob/main/ib-v2/src/protocol/oracle/PriceOracle.sol#L104

Tool used

Manual Review

Recommendation

Consider creating oracles specific for L2s that use chainlink feeds for two reasons:

  • Missing an official chainlink registry
  • L2 sequencer checks need to be added

Duplicate of #191

@github-actions github-actions bot added Medium A valid Medium severity issue Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label labels Jun 19, 2023
@sherlock-admin sherlock-admin added the Reward A payout will be made for this issue label Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label Medium A valid Medium severity issue Reward A payout will be made for this issue
Projects
None yet
Development

No branches or pull requests

1 participant