Skip to content
This repository has been archived by the owner on Dec 17, 2023. It is now read-only.

rvierdiiev - Missing checks for whether Arbitrum Sequencer is active #10

Closed
sherlock-admin opened this issue Jun 11, 2023 · 0 comments
Closed
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label Medium A valid Medium severity issue Reward A payout will be made for this issue

Comments

@sherlock-admin
Copy link
Contributor

sherlock-admin commented Jun 11, 2023

rvierdiiev

medium

Missing checks for whether Arbitrum Sequencer is active

Summary

PriceOracle doesn't check whether the Arbitrum Sequencer is active when using prices from chainlink oracle.

Vulnerability Detail

Iron Bank protocol is going to launch on arbitrum network.
PriceOracle is using chainlink oracle in order to get prices. Chainlink recommends to check if arbitrum sequencer is active in order to get fresh prices. Otherwise stale prices can be fetched.

Impact

PriceOracle can calculate prices incorrectly which can cause bad debt for a protocol.

Code Snippet

https://github.com/sherlock-audit/2023-05-ironbank/blob/main/ib-v2/src/protocol/oracle/PriceOracle.sol#L66-L72

Tool used

Manual Review

Recommendation

Check that sequencer is not down.

Duplicate of #440

@github-actions github-actions bot added Medium A valid Medium severity issue Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label labels Jun 19, 2023
@sherlock-admin sherlock-admin added the Reward A payout will be made for this issue label Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label Medium A valid Medium severity issue Reward A payout will be made for this issue
Projects
None yet
Development

No branches or pull requests

1 participant