Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax errors and ParentNode.prepend not supported in IE #239

Merged
merged 2 commits into from
Sep 7, 2018

Conversation

alexdaube
Copy link
Contributor

@alexdaube alexdaube commented Sep 6, 2018

I was testing with release 2.0.0-beta-24 in IE and some errors occurred. Issue 238

Basically putting the babel/env back in the webpack config seem make IE load the lib instead of giving us the awful Syntax Errors message.

Also, ParentNode.prepend is not fully supported by all the browsers, so it's probably better not to use it since it doesn't seem to be needed in this case.

Cheers!

Resolves #238

@RobbieTheWagner
Copy link
Member

Hi @alexdaube thanks for letting us know about this, and thanks for the PR! I think the issue was we didn't have a browserslist config, so it was not supporting IE as it should. I just added one. Can you see if that fixes things for you? I think we may not need the webpack config changes, now that we have the browserslistrc.

@alexdaube
Copy link
Contributor Author

On it @rwwagner90 👍.

@alexdaube
Copy link
Contributor Author

@rwwagner90 . I guess I didn't look well enough earlier, as the babel-preset config was moved into the babel.config.js. The browserslistrc seem to be resolving the lib loading issue in IE, which is excellent. For header.prepend(title);, the issue is still present.

@RobbieTheWagner RobbieTheWagner merged commit d52e54a into shipshapecode:master Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants