Add some tour tests #216
Merged
Add some tour tests #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let name, step; | ||
|
|
||
| // If we just have one argument, we can assume it is an object of step options, with an id | ||
| if (_.isUndefined(arg2)) { |
There was a problem hiding this comment.
what's the benefit of renaming the args?
There was a problem hiding this comment.
They were not truly name and step. Really, this is behaving as an overloaded method. If there is just one arg, there is no name, but name is the first param. It confused me with the naming, so I renamed them.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.