-
-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrolling to an element causes modal overlay to appear in wrong place #319
Comments
Can you provide a reproduction of this? I've used |
Thanks for the quick response. I've attached a one-page HTML example that demonstrates the problems. After some more digging, I found the culprit is the scrolling div within the page. If I remove the style elements from the div, everything works fine - i.e. if the page itself scrolls, it works, if some part of the page scrolls it doesn't. |
@rswheeldon that makes sense, as our scroll listener is on the window, so scrolling other elements probably would not fire it. |
@chuckcarpenter @BrianSipple how should we handle this? We probably do not want to add scroll listeners to every element on the page right? |
maybe see what element triggered the listener? Only reacting on |
If I set up a tour with the following
And have a step in the tour which requires scrolling, then the window scrolls so the element is visible but puts the mask in the place which would have covered the element in its previous position.
The text was updated successfully, but these errors were encountered: