Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"max" does not work properly when selecting all items in an option group #1398

Closed
Yosi85 opened this issue Feb 17, 2021 · 8 comments · Fixed by #1580
Closed

"max" does not work properly when selecting all items in an option group #1398

Yosi85 opened this issue Feb 17, 2021 · 8 comments · Fixed by #1580
Assignees
Labels
Milestone

Comments

@Yosi85
Copy link

Yosi85 commented Feb 17, 2021

When using option groups it is possible to select more item than what is defined in max

Reproduction Link

https://jsfiddle.net/q4xb5ns6/

Steps to reproduce

Select the "test" group to select all its items

Expected behaviour

Only 2 items are selected because max is set to 2

Actual behaviour

All items are selected

@lehoaibaokg
Copy link

To do that we can remove the last items of the value manually (using splice) if the value.length is greater than or equal to the max value on the @input event.

@akki-jat
Copy link
Collaborator

@Yosi85 Please provide new production link as old one is not working.

@Yosi85
Copy link
Author

Yosi85 commented Oct 28, 2022

@akki-jat I've created a new jsFiddle as requested. https://jsfiddle.net/10wvLmng/1/

@akki-jat akki-jat added bug and removed needs repro labels Oct 28, 2022
@akki-jat akki-jat added this to the 2.1.7 release milestone Oct 28, 2022
@akki-jat akki-jat self-assigned this Oct 28, 2022
@akki-jat
Copy link
Collaborator

@Yosi85 - Thanks for quick response.

@akki-jat akki-jat linked a pull request Oct 29, 2022 that will close this issue
@lehoaibaokg
Copy link

@Yosi85 Please provide new production link as old one is not working.

Just add vue2 cdn url to resources, it will work

@akki-jat
Copy link
Collaborator

@Yosi85 / @lehoaibaokg Opened the PR, please take a look.

#1580

@Yosi85
Copy link
Author

Yosi85 commented Nov 1, 2022

Thanks for fixing this. Any idea when 2.1.7 is going live?

@mattelen
Copy link
Collaborator

mattelen commented Nov 1, 2022

Check out the discussion happening around the release here: #1589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants