From ad3bad4fd8c2d8af630d51f9b652246283895f8e Mon Sep 17 00:00:00 2001 From: Chris Fillmore Date: Fri, 9 Feb 2018 14:01:20 -0500 Subject: [PATCH 1/2] Remove misleading logging in DrmEngine#fillInDrmInfoDefaults_ Closes #1284 --- lib/media/drm_engine.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/media/drm_engine.js b/lib/media/drm_engine.js index 1359f73553..3b988320bb 100644 --- a/lib/media/drm_engine.js +++ b/lib/media/drm_engine.js @@ -693,8 +693,6 @@ shaka.media.DrmEngine.prototype.fillInDrmInfoDefaults_ = function(drmInfo) { var server = this.config_.servers[keySystem]; if (server) { drmInfo.licenseServerUri = server; - } else { - shaka.log.error('No license server configured for ' + keySystem); } } From 9bd3285b715e474c4872be4d2e143d534edf08fd Mon Sep 17 00:00:00 2001 From: Chris Fillmore Date: Mon, 12 Feb 2018 06:24:59 -0500 Subject: [PATCH 2/2] Update drm_engine_unit not to expect error logging. --- test/media/drm_engine_unit.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/test/media/drm_engine_unit.js b/test/media/drm_engine_unit.js index 3d85a803a7..026e745b60 100644 --- a/test/media/drm_engine_unit.js +++ b/test/media/drm_engine_unit.js @@ -497,12 +497,10 @@ describe('DrmEngine', function() { requestMediaKeySystemAccessSpy.and.callFake( fakeRequestMediaKeySystemAccess.bind(null, ['drm.abc'])); - logErrorSpy.and.stub(); config.servers = {}; drmEngine.configure(config); drmEngine.init(manifest, /* offline */ false).then(fail, function(error) { - expect(logErrorSpy).toHaveBeenCalled(); shaka.test.Util.expectToEqualError(error, new shaka.util.Error( shaka.util.Error.Severity.CRITICAL, shaka.util.Error.Category.DRM,