Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot redefine property: fullscreenElement #81

Closed
JobaDiniz opened this issue May 14, 2015 · 1 comment
Closed

Cannot redefine property: fullscreenElement #81

JobaDiniz opened this issue May 14, 2015 · 1 comment
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@JobaDiniz
Copy link

Hi, I'm guessing this condition is wrong (taken from here):

if (!document.fullscreenElement) {
    Object.defineProperty(document, 'fullscreenElement', {
      get: function() {
        return document.mozFullScreenElement ||
               document.msFullscreenElement ||
               document.webkitFullscreenElement;
      }
    });
  }
@joeyparrish joeyparrish added this to the v1.3.1 milestone May 18, 2015
@joeyparrish joeyparrish self-assigned this May 18, 2015
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label May 18, 2015
@joeyparrish
Copy link
Member

Already fixed in master by 7ea820c, but we'll leave this open until we've released v1.3.1, which will contain a cherry-pick of this fix. Thanks!

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants