Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Offline): Fix some aborted downloads continue to download #7842

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

avelad
Copy link
Member

@avelad avelad commented Jan 8, 2025

Fixes #6311

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround component: offline The issue involves the offline storage system of Shaka Player labels Jan 8, 2025
@avelad avelad added this to the v4.13 milestone Jan 8, 2025
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 75.00%

@avelad avelad merged commit fb8086b into shaka-project:main Jan 8, 2025
23 checks passed
@avelad avelad deleted the store-abort branch January 8, 2025 11:57
@loicraux
Copy link
Contributor

Thanks a lot @avelad !! 👍🏻 🥇

I should be able to remove a whole piece of workaround code in my app !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: offline The issue involves the offline storage system of Shaka Player priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Offline Storage] Some aborted/interrupted downloads continue to download
4 participants