Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Periods are not being switched automatically during playback (regression) #463

Closed
Ross-cz opened this issue Jul 26, 2016 · 9 comments
Closed
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@Ross-cz
Copy link
Contributor

Ross-cz commented Jul 26, 2016

Using Heliocentrism demo on the beta-2 site http://shaka-player-demo.appspot.com/demo/ playback works.
Using Heliocentrism demo on the v2.0.0-beta2-140-g022226c-debug http://nightly.shaka-player-demo.appspot.com/demo/ plays only 1.999201 sec and wheel keeps rotating.

@joeyparrish joeyparrish self-assigned this Jul 26, 2016
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Jul 26, 2016
@joeyparrish joeyparrish added this to the v2.0.0 milestone Jul 26, 2016
@joeyparrish
Copy link
Member

Confirmed. Thanks for the report.

@joeyparrish
Copy link
Member

Bisect shows it was broken by ab86551. @baconz as JFYI

@baconz
Copy link
Contributor

baconz commented Jul 26, 2016

Sorry about that! Looking

@baconz
Copy link
Contributor

baconz commented Jul 26, 2016

Looks like this manifest has no MPD, but is static. I didn't realize that was allowed.

Thoughts on keying off of type to determine whether a manifest isLive? It seems like that's the best possible indicator.

@joeyparrish
Copy link
Member

No MPD?

@joeyparrish
Copy link
Member

Oh, you mean mediaPresentationDuration? Yes, that's definitely allowed. The presentation duration can be derived from period durations.

@baconz
Copy link
Contributor

baconz commented Jul 26, 2016

Got it. Thoughts on using type for this?

@joeyparrish
Copy link
Member

Your in-progress VOD content has a known, finite duration, correct? And type="static" or type="dynamic"? It would be helpful to have a public sample of such content we could use if this type of content is something we want to continue to support.

@baconz
Copy link
Contributor

baconz commented Jul 26, 2016

Yep, exactly. Here's a summary of how it is set up right now: #442 (comment)

I can update with a sample mpd in a bit.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants