Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.x: Improve DASH parser performance w/ large timeshift depths #449

Closed
joeyparrish opened this issue Jul 18, 2016 · 3 comments
Closed

v1.x: Improve DASH parser performance w/ large timeshift depths #449

joeyparrish opened this issue Jul 18, 2016 · 3 comments
Labels
status: archived Archived and locked; will not be updated

Comments

@joeyparrish
Copy link
Member

In #405, we improved DASH parser performance for large timeshift depths by deferring filling URI templates. Investigate whether or not this can be easily implemented in v1.6.x as well.

@joeyparrish
Copy link
Member Author

@torerikal mentioned that this fix was in their fork: vimond/shaka-player@adbcdb5

@torerikal, @janouskovec, any interest in cleaning it up and creating a PR?

I think it's a good start, but the subclass should call the base class's constructor instead of re-creating all of its members. There also doesn't seem to be any need to make everything protected, just make urls non-const.

@janouskovec
Copy link

In fact no need creating PR for me, because I already fixed the issue in my local repository and push now to my fork: janouskovec@Deferring filling URI templates.

@joeyparrish joeyparrish removed the type: enhancement New feature or request label Jul 29, 2016
@joeyparrish
Copy link
Member Author

Okay, closing for lack of interest. If anybody wants to patch v1 for this, please feel free to reply and we can reopen.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

No branches or pull requests

3 participants