Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11 promises working when compiled #236

Closed
sarge opened this issue Nov 26, 2015 · 1 comment
Closed

IE11 promises working when compiled #236

sarge opened this issue Nov 26, 2015 · 1 comment
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly

Comments

@sarge
Copy link

sarge commented Nov 26, 2015

Running the compiled version on IE11 does not find the resolve and reject methods on the promise polyfill

Load in IE11 and attempt play anything
https://shaka-player-demo.appspot.com/?compiled

The promise implementation only appears to work when compiling using -O SIMPLE -D COMPILED=false

Probably a simple fix for someone who knows their way around the closure compiler.

Cheers

Mark

@joeyparrish joeyparrish self-assigned this Nov 28, 2015
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Nov 28, 2015
@joeyparrish
Copy link
Member

Thanks, Mark. We made a mistake there for sure.

My first thought was that we should have exported the static methods, but that doesn't seem to work without exporting the constructor as well. Instead, it looks like we will have to assign the static methods in the polyfill's installer.

Shouldn't take long to publish a fix, which we will roll into v1.6.1.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants