Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLS starts at 10s #1793

Closed
mseeley opened this issue Feb 6, 2019 · 10 comments
Closed

HLS starts at 10s #1793

mseeley opened this issue Feb 6, 2019 · 10 comments
Labels
status: archived Archived and locked; will not be updated status: duplicate A duplicate of another issue; should be closed after linking to the original issue

Comments

@mseeley
Copy link

mseeley commented Feb 6, 2019

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?

  • Shaka: 2.4.6, 2.4.5, and 2.3.3.
  • Our custom app combines Shaka v2.3.3 + mux.js v5.0.1. We are trying to update to Shaka >= v2.4.6 + mux.js v5.0.1.

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from master?
No, I honestly have not tried.

Are you using the demo app or your own custom app?
Demo and custom app.

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
Chrome 72, macOS 10.14.1

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
n/a

What are the manifest and license server URIs?

What did you do?

  • Load the 2.4.6 demo directly to the manifest above
    • Maximum small gap size: should be default 0.5
    • Jump large gaps is unchecked

What did you expect to happen?

Playback should begin at 0s. In our app, v2.3.3 + mux.js v5.0.1 play the stream from start time 0 without manifest.defaultPresentationDelay nor manifest.hls.defaultTimeOffset values. I believe there is a behavior change between 2.3.3 and 2.4.5 that I haven't been able to identify.

What actually happened?

  • Stream jumps forwards to ~10s.
  • Log displays Jumping forward 0.1154080000000004 seconds because of gap starting at 11.862333 and ending at 11.947666

Our upgrade to 2.4.5 and 2.4.6 both demonstrate that stream playback now starts at ~10s. The delay smells like a pre-roll presentation delay of some sort. It did not occur in 2.3.3.

These issues describe a 10s skip at start: #1625, #1011. The combined configuration workaround (shown below) doesn't change behavior.

this._shaka.configure({
  manifest: {
    // #1625
    defaultPresentationDelay: 0,
    hls: {
      // #1011
      defaultTimeOffset: 0
    }
  },
  streaming: {
    bufferingGoal: this.props.bufferingGoal,
    jumpLargeGaps: true,
    retryParameters: {
      maxAttempts: Infinity
    }
  },
  abr: {
    defaultBandwidthEstimate: this.props.defaultBandwidthEstimate
  }
});

kapture 2019-02-05 at 14 57 00

@mseeley mseeley changed the title HLS starts at 10s due to jump forward HLS starts at 10s Feb 6, 2019
@vaage
Copy link
Contributor

vaage commented Feb 6, 2019

@mseeley Most HLS content starts at 10 seconds, this is something that Apple's HLS packager does and so a lot of content starts at 10 seconds.

Is the player:

  • skipping the first 10 seconds of your content

or is the player:

  • saying your contents at timer=10 seconds and no actual content was skipped

@vaage vaage added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Feb 6, 2019
@mseeley
Copy link
Author

mseeley commented Feb 6, 2019

HI @vaage good question. I've just confirmed; the player is skipping the first 10s of content.

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Feb 6, 2019
@mseeley
Copy link
Author

mseeley commented Feb 7, 2019

@vaage, #1625 mentions a fix in 2.50 beta. I can confirm this is fixed in the 2.5.0-beta2 npm package without any of the configuration mentioned above. Diff: https://gist.github.com/mseeley/908f51ac71e33d08797857d742b34296.

@vaage
Copy link
Contributor

vaage commented Feb 7, 2019

@joeyparrish was #1602 cherry-picked into 2.4 (I don't see it in the changelog)? If not, is there any way to flag it to be cherry-picked in the future?

@joeyparrish
Copy link
Member

It was not, but I just pushed it to v2.4.x in cd9d066, which will be released in v2.4.7. Sorry for the inconvenience! I didn't realize we had missed that fix.

@mseeley
Copy link
Author

mseeley commented Feb 8, 2019

Thank you @vaage and @joeyparrish! Zero worries here. 😄

@mseeley
Copy link
Author

mseeley commented Feb 19, 2019

Hi @joeyparrish 👋. I've been sleuthing in this repo to find a general 2.4.7 release plan/timing although I haven't found information. Will you please share some general thoughts on 2.4.7? No pushy request to release, just a request for a bit of context I can use to update state on our internal issue tracker. Thanks!

@joeyparrish
Copy link
Member

Hi, @mseeley. I'm working on it today. We're a bit behind on everything, which is hard to tell since I haven't published a timeline or roadmap yet. That's coming soon, too, though.

@joeyparrish
Copy link
Member

Just noticed that this is still in "needs triage". I'm going to go ahead and close as a duplicate of #1602 based on the history so far. The fix for that is in master (so you can try it out any time) and will be rolled into v2.4.7 very soon. Thanks!

@joeyparrish joeyparrish added status: duplicate A duplicate of another issue; should be closed after linking to the original issue and removed needs triage labels Feb 19, 2019
@joeyparrish
Copy link
Member

Fix released in v2.4.7.

@shaka-project shaka-project locked and limited conversation to collaborators Apr 20, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated status: duplicate A duplicate of another issue; should be closed after linking to the original issue
Projects
None yet
Development

No branches or pull requests

4 participants