Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffering spinner is offset from play button #1695

Closed
joeyparrish opened this issue Nov 21, 2018 · 2 comments
Closed

Buffering spinner is offset from play button #1695

joeyparrish opened this issue Nov 21, 2018 · 2 comments
Assignees
Labels
component: UI The issue involves the Shaka Player UI status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@joeyparrish
Copy link
Member

joeyparrish commented Nov 21, 2018

Have you read the FAQ and checked for duplicate open issues?:
Yes

What version of Shaka Player are you using?:
master

Can you reproduce the issue with our latest release version?:
N/A

Can you reproduce the issue with the latest code from master?:
Yes

Are you using the demo app or your own custom app?:
Demo

What browser and OS are you using?:
Chrome on Linux

What are the manifest and license server URIs?:
N/A, any demo asset

What did you do?
Click "Load"

What did you expect to happen?
The buffering spinner is aligned with the play button

What actually happened?
The buffering spinner is offset and above the play button

This is easier to see and investigate if you use the debugger to enable the spinner without loading content.

@joeyparrish joeyparrish added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI labels Nov 21, 2018
@joeyparrish joeyparrish self-assigned this Nov 21, 2018
@shaka-bot shaka-bot added this to the v2.5 milestone Nov 21, 2018
@joeyparrish
Copy link
Member Author

Correction: The position of the spinner is correct for some video aspect ratios, but not others. Sintel is a problem, but Angel One is not.

@joeyparrish
Copy link
Member Author

joeyparrish commented Nov 21, 2018

The easiest repro is to select Sintel (possibly twice, because of #1696), load the content, pause the content, then open the debugger and uncheck the style "display: none" on class "shaka-buffering-spinner".

@shaka-project shaka-project locked and limited conversation to collaborators Jan 25, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: UI The issue involves the Shaka Player UI status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

2 participants