fix: Avoid duplicate calls to decodingInfo() #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theodab
requested changes
Jun 3, 2022
| if (!mediaKeySystemAccess) { | ||
| capabilities.keySystemAccess = | ||
| await McEncryptionSchemePolyfill.getMediaKeySystemAccess_( | ||
| requestedConfiguration); |
There was a problem hiding this comment.
This case could use a comment. Something to explain that this is avoiding unnecessary calls to the original decodingInfo calls, by doing the only remaining thing the polyfill would need to do in this situation, perhaps?
There was a problem hiding this comment.
I added comments here, and reworded others to try to clarify things. PTAL!
theodab
approved these changes
Jun 7, 2022
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
probeDecodingInfo_(), ifnavigator.mediaCapabilitiesreturns the decodingInfo results but has no keySystemAccess information for encrypted content, we can callnavigator.requestMediaKeySystemAccessto patch the keySystemAccess information.This avoids a few unnecessary calls of
decodingInfo.Built on abandoned PR #19 by @michellezhuogg