Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variants for Input Component #2425

Closed
ahmedsomaa opened this issue Jan 14, 2024 · 9 comments
Closed

Variants for Input Component #2425

ahmedsomaa opened this issue Jan 14, 2024 · 9 comments
Labels

Comments

@ahmedsomaa
Copy link

Title: Enhancement Proposal - Input Component Variants: Outlined, Filled, Standard

Issue Description:
The current Input component have one UI appearance which is the outlined one. Can we introduce two other variants: filled and standard one. Check the demo for the difference between the three versions.

Demo:
Screenshot 2024-01-14 at 21-53-12 Tailwind CSS Floating Label - Flowbite
The image was taken from tailwind flowbite here.

@thought7878
Copy link

@shadcn Can i work on this feature? If you approve, I can start working on it.

@ahmedsomaa
Copy link
Author

@thought7878 I believe you can work on it and then open a PR for it. The PR would have to be reviewed and closed by @shadcn.

@shadcn shadcn added the Stale label Feb 8, 2024
@shadcn
Copy link
Collaborator

shadcn commented Feb 15, 2024

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.

@shadcn shadcn closed this as completed Feb 15, 2024
@hsuanyi-chou
Copy link

@ahmedsomaa
here

@sai-tanush
Copy link

sai-tanush commented Sep 20, 2024

@ahmedsomaa here
this ui is bad

@juanpablob
Copy link

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.

I think it was closed by accident? There was indeed activity, someone offered to work in a MR but you did not provide any answer or feedback. It is something that quite a few people have been asking here and there.

@ahmedsomaa
Copy link
Author

I believe it's not necessary any more since we have other community components built on shadcn and you can also install it using the shadcn CLI. One of my favorite ones is Origin UI, they have multiple variants for many components. Check it here

@juanpablob
Copy link

juanpablob commented Feb 4, 2025

Hey, thanks for your reply! Seems cool Origin UI, but none of these variants include a "small" input, for instance 😅 that is way i was asking, because it would be nice if shadcn would support size variants, in the same way Radix UI supports them.

@ahmedsomaa
Copy link
Author

Totally agree. I think we already have that for some components like Button; we have default, sm, lg & icon. I believe we would need a new issue to add support for size variants for all components (that don't have this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants