Readall rename and Js loading default #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
readall has been renamed to readstring
Doesn't change current behaviour but enables having plotly.js javascript file loaded via embed or from cdn. InteractNext will set it to :embed by default, which will make it easier to support PlotlyJS in Mux, Blink, and Juno.
JobJob
added a commit
to JuliaGizmos/InteractNext.jl
that referenced
this pull request
Jul 8, 2017
simplfies plotlyjs support further - requires JuliaPlots/PlotlyJS.jl#127
1 task
|
Looks innocent enough , thanks! Let me know when WebIO and InteractNext are ready to go! |
|
Thanks! Will do :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readallhas been renamed toreadstringon Julia 0.6InteractNext will set
js_defaultto :embed (using Requires.jl - code here) which will make it easier to support PlotlyJS in Mux, Blink, and Juno.