-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rechunking to save_dataset
#981
Comments
Good question. When we added At a minimum we could improve the documentation, and give some examples (including at https://pystatgen.github.io/sgkit/latest/how_do_i.html#save-results-to-a-zarr-file). We could also add an optional parameter to |
Thanks @tomwhite. I agree with your point about auto-rechunking being a heavy operation and it should be opt-in. I think adding an opt-in parameter to |
I agree - this sounds like a good addition. |
save_dataset
This was mentioned in #296 too. |
I'm creating a workflow where I need to subset the variants in a dataset and write it back to zarr. However:
Results in:
ValueError: Final chunk of Zarr array must be the same size or smaller than the first.
Or with more chunks:
ValueError: Zarr requires uniform chunk sizes except for final chunk.
I could rechunk all the arrays with a variants dimension - this doesn't make for an easy time for the average user though.
Should
save_dataset
auto rechunk in these situations?The text was updated successfully, but these errors were encountered: